Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splatoon 3 Alterna and Side Order #183

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Splatoon 3 Alterna and Side Order #183

merged 3 commits into from
Sep 4, 2024

Conversation

AbandonedCart
Copy link
Contributor

Pull request form

Checklist

  • The ids provided are not spoof.
  • The ids provided are all in lowercase.
  • The game_info.json had been updated with the corresponding ids.
  • Images of amiibo had been provided with the highest quality.

Link to amiibo.life for amiibo

See #181
Running the game-info generator returned 429 Too many requests so they are blank

@AbandonedCart
Copy link
Contributor Author

Let me know if you prefer - Side Order formatting instead and I’ll change it.

@N3evin
Copy link
Owner

N3evin commented Sep 4, 2024

Let me know if you prefer - Side Order formatting instead and I’ll change it.

It should be fine for now.

Do you mind PR to dev branch instead of master?

I will merge it tomorrow morning. As I'm currently away from home.

@AbandonedCart
Copy link
Contributor Author

AbandonedCart commented Sep 4, 2024

No problem. I forgot to change it when selecting branches.

I should probably do an actual rebase to drop the merge commits. I’ll do it as soon as I’m back at the computer.

@AbandonedCart AbandonedCart changed the base branch from master to dev September 4, 2024 15:33
@N3evin N3evin merged commit a626621 into N3evin:dev Sep 4, 2024
1 check passed
@N3evin
Copy link
Owner

N3evin commented Sep 5, 2024

Let me know if you prefer - Side Order formatting instead and I’ll change it.

Putting here as a note, had change it to this format instead. So it can crawl for game info.

@AbandonedCart
Copy link
Contributor Author

Sounds good. I got my copy of the generator from the original repo, so I will pull this one and hopefully next time I can spare you the hassle. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants