This repository has been archived by the owner on May 1, 2022. It is now read-only.
feat: annotation > converter specifiers #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is dirty.
|
Ready for review! The logic behind it is somewhat hacky, so I'm interested in doing reviews, comments, etc.. |
Merged
AstreaTSS
commented
Apr 7, 2022
molter/command.py
Outdated
| # when this is merged with dis-snek, parameters will be analyzed either | ||
| # when the client reads its own commands or when a scale is loaded, | ||
| # instead of on creation. that will remove the need for this | ||
| command.parse_parameters(has_self=_is_nested(command.callback)) |
There was a problem hiding this comment.
I'll review myself SMH.
This section is the only section I have concerns with. I would like to do a less naive approach where we go through each parameter and only redo the ones that are needed here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea discussed on the
dis-snekserver was the idea to allow normal annotations to be use in Molter commands by tying a converter to them. This is what is done fordis-snekobjects, actually, but allowing user-defined "injections" would be nice as well.Take, for example:
Molter would be able to take care of the conversion just with that decorator.
This PR is not done and in fact is just a draft. Reviews and contributions are encouraged.