Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ait-seq-encode and ait-seq-decode are inconsistent #330

Closed
MJJoyce opened this issue Mar 19, 2021 · 0 comments · Fixed by #334
Closed

ait-seq-encode and ait-seq-decode are inconsistent #330

MJJoyce opened this issue Mar 19, 2021 · 0 comments · Fixed by #334

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Mar 19, 2021

The tool ait-seq-encode expects filenames to be formatted mission_seq_SSS_desc_NNN.txt and produces mission_seq_SSS_desc_NNN.bin, but ait-seq-decode expects filenames to be formatted mission_seq_SSS_NNN_desc.bin.

This makes it inconvenient to decode a just encoded sequence (for verification).

Thanks to @bornstei for noting and reporting this
MJJoyce added a commit that referenced this issue Mar 19, 2021
@MJJoyce
Issue #330 - Fix seq encode / decode input format consistency
c4af6a5 
Update ait_seq_decode so the expected input file name format matches
that of ait_seq_encode.

Resolve #330
@MJJoyce MJJoyce mentioned this issue Mar 19, 2021
Merged
MJJoyce added a commit that referenced this issue Mar 19, 2021
@MJJoyce
Merge pull request #334 from NASA-AMMOS/issue-330
5c92351 
Issue #330 - Fix seq encode / decode input format consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #330 - Fix seq encode / decode input format consistency NASA-AMMOS/AIT-Core
1 participant
@MJJoyce