Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seq should not require a sequence id on initialization #335

Closed
MJJoyce opened this issue Mar 19, 2021 · 0 comments · Fixed by #336
Closed

Seq should not require a sequence id on initialization #335

MJJoyce opened this issue Mar 19, 2021 · 0 comments · Fixed by #336

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Mar 19, 2021

Seq errors out if you don't provide it with a sequence ID during initialization due to

self.seqid     = int(id)

Seq will read a provided filename and extract out the encoded sequence id when provided with an encoded sequence. With the above, this doesn't work.
MJJoyce added a commit that referenced this issue Mar 19, 2021
@MJJoyce
Issue #335 - Make Seq sequence id optional on initialization
585e652 
Seq no longer tries to cast the sequence `id` argument on initialization so
creating a new Seq without an id is valid. This is useful when creating
a Seq from a binary encoded sequence file in which the sequence id is
encoded. By default, it will parse this out for you.

Resolve #335
@MJJoyce MJJoyce mentioned this issue Mar 19, 2021
Merged
MJJoyce added a commit that referenced this issue Mar 19, 2021
@MJJoyce
Merge pull request #336 from NASA-AMMOS/issue-335
e350abd 
Issue #335 - Make Seq sequence id optional on initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #335 - Make Seq sequence id optional on initialization NASA-AMMOS/AIT-Core
1 participant
@MJJoyce