Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid log message formatting in ait-seq-encode #337

Closed
MJJoyce opened this issue Mar 23, 2021 · 0 comments · Fixed by #338
Closed

Invalid log message formatting in ait-seq-encode #337

MJJoyce opened this issue Mar 23, 2021 · 0 comments · Fixed by #338

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Mar 23, 2021

ait-seq-encode is throwing errors while encoding and writing a sequence to a file because the value passed to a format string is not an expected int (presumably this is no longer converting automatically in 2.x -> 3.x?).

TypeError: %x format: an integer is required, not str

It looks like this happens in 1 or 2 spots. A quick update of the format strings should clear this up
MJJoyce added a commit that referenced this issue Mar 23, 2021
@MJJoyce
Issue #337 - Update ait-seq-encode log message formatting
1359ac9 
Update all ait-seq-encode log messages to use f-strings. Fix a bug with
seqid not being saved after a cast to int and this causing an error when
formatting a log message during sequence write.

Resolve #337
@MJJoyce MJJoyce mentioned this issue Mar 23, 2021
Merged
MJJoyce added a commit that referenced this issue Mar 23, 2021
@MJJoyce
Merge pull request #338 from NASA-AMMOS/issue-337
b8d3261 
Issue #337 - Update ait-seq-encode log message formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #337 - Update ait-seq-encode log message formatting NASA-AMMOS/AIT-Core
1 participant
@MJJoyce