Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #285 - Added more log info into dmc.py #288

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

acliu88
Copy link
Contributor

@acliu88 acliu88 commented Jul 23, 2020

Updated dmc.py with more logging information when pulling, loading, or generating leapsecond.dat file.

Added more logging information when loading leapsecond.dat

Resolve Ticket NASA-AMMOS#285
Updated dmc.py Logging info
@acliu88 acliu88 requested review from a team as code owners July 23, 2020 20:12
Copy link
Member

@MJJoyce MJJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @acliu88! One minor comment inline. If you could make a quick change to that I'll go ahead and merge.

Thanks!

ait/core/dmc.py Outdated
Comment on lines 308 to 310
t = self._data['valid']
t.strftime('%m/%d/%Y')
log.info('Leapseconds data valid until %s', t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to print the default format for t. Something like this:

>>> print(ait.core.dmc._data['valid'])
2020-12-28 00:00:00

You need to store the return value from strftime to change the format.

assigned variable to log info output.
@MJJoyce MJJoyce merged commit 86d5811 into NASA-AMMOS:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants