Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 358: OpenMCT Plugin support for multiple clients and filtered telemetry #426

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

nttoole
Copy link
Contributor

@nttoole nttoole commented Mar 24, 2022

Refactored the plugin to maintain a set of active-websockets to which realtime telemetry will be sent.
Server also maintains state of web-socket by handling messages: subscribe, unsubscribe, close
Each web-socket maintains a set of subscribed telemetry fields, so only those fields will be transmitted to the web-socket.

We also refactored how the AIT-OpenMct extensions are integrated with OpenMCT. No longer do we download OpenMCT and modify its internal files. Instead, we offer an example web-server that imports openmct as a dependency. This removes an earlier requirement of using an older version of OpenMCT (before they adopted Webpack).

Finally, updated documentation to capture the new approach for deployment.

Testing involved an AIT Config YAML with the following plugin info:

          - plugin:
              name: ait.core.server.plugins.openmct.AITOpenMctPlugin
              inputs:
                - telem_stream
              service_port: 8082
              debug_enabled: True
              database_enabled: False

Testing notes particular to each issue are captured in the issue.

Fixes #357
Fixes #358
Fixes #359

@nttoole nttoole requested review from a team as code owners March 24, 2022 18:51
Copy link
Contributor

@jasonmlkang jasonmlkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried running ait-server with openmct example server. LGTM!

@nttoole nttoole merged commit ec89a3e into master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants