Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nullable receiving and supplying plans for merge reviews #1508

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Oct 14, 2024

Partially closes #1507 though requires a backend change that would automatically change a merge request status to withdrawn when the supplying plan is deleted during an active request.

TODO:

  • e2e tests
  • Should a user be allowed to begin a review if the source plan has been deleted?
  • What should we do about merge requests that are stuck in pending if we don't do ^
  • Should a user be allowed to withdraw a review if the target plan has been deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to open merge request
1 participant