Add new membership / latest test cases for test suite #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdunnjpl
requested review from
nutjob4life,
tloubrieu-jpl and
al-niessner
as code owners
alexdunnjpl
force-pushed
the
membership-latest-tests
branch
from
c900be8
to
e99f92a
Compare
alexdunnjpl
force-pushed
the
membership-latest-tests
branch
from
e99f92a
to
47eca46
Compare
|
Postpone merge until resolution of #300 |
|
@tloubrieu-jpl @nutjob4life could I please get a second/third pair of eyes on the fixes derived from #300 ? I've triple-checked the changes and run the updated tests to confirm they pass, but wouldn't hurt. |
tloubrieu-jpl
approved these changes
Jul 24, 2024
Nothing jumps out at me … let's go for it |
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Implement tests
Adds default docker credentials for ease of development
⚙️ Test Data and/or Report
Adds new tests and trivially-modifies a couple of others. All relevant tests pass
♻️ Related Issues
fixes NASA-PDS/registry-api#484
fixes NASA-PDS/registry-api#485
fixes NASA-PDS/registry-api#486
fixes NASA-PDS/registry-api#487