Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tf workflow #28

Merged
merged 2 commits into from
Jul 12, 2023
Merged

add tf workflow #28

merged 2 commits into from
Jul 12, 2023

Conversation

sjoshi-jpl
Copy link
Contributor

🗒️ Summary

Added terraform cicd workflow

⚙️ Test Data and/or Report

One of the following should be included here:

  • Reference to regression test included in code (preferred wherever reasonable)
  • Attach test data here + outputs of tests

♻️ Related Issues

Ref - NASA-PDS/devops#52

@sjoshi-jpl
Copy link
Contributor Author

Note: the tests will fail since it's looking for repository variables which cannot be supplied as these are just example templates.

branches:
- '**'
pull_request:
types: [opened, edited, reopened, ready_for_review, review_requested]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjoshi-jpl do we want to run these TF workflows on PRs/branches? I was thinking we would only want to deploy these things when they are merged to main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordanpadams yes but I can limit the number of times this workflow gets executed by only running terraform plan on PR creation and push to main.

more details

@jordanpadams
Copy link
Member

@sjoshi-jpl I added workflow_dispatch: to this and the other 2 PRs. if you agree with that, go ahead with a merge.

@jordanpadams jordanpadams merged commit 1b63eca into main Jul 12, 2023
@jordanpadams jordanpadams deleted the terraform-workflow branch July 12, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants