Fix TRAVIS tests following multi-suite static build #185
Conversation
…issing SUITES_DIR variable in CCPP prebuild config
climbfuji
requested review from
gold2718,
grantfirl and
llpcarson
as code owners
| @@ -45,6 +45,9 @@ | |||
| # Directory where to put all auto-generated physics caps | |||
| CAPS_DIR = '.' | |||
|
|
|||
| # Directory where the suite definition files are stored | |||
| SUITES_DIR = '../../../../../src/tests' | |||
There was a problem hiding this comment.
Not very pythonic. Any reason you are not using os.path?
There was a problem hiding this comment.
I guess no, no particular reason. Would have to redo the entire file, though, since all other entries are in the same way. I will probably leave this for another cleanup PR, if it gets done at all before moving to cap_gen. Note that I had to change a few more files, including some changes that need to be tested with NEMSfv3gfs. I will conduct the tests in conjunction with upcoming PRs (will be listed below shortly) and have them merged together.
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage ? 47.28%
=========================================
Files ? 14
Lines ? 1343
Branches ? 0
=========================================
Hits ? 635
Misses ? 708
Partials ? 0
Continue to review full report at Codecov.
|
This is a bug fix following the multi-suite static build PR #183.
Add missing SUITES_DIR variable in CCPP prebuild config of travis test config to fix travis build errors. Add switch to ccpp_init that indicates that the specified suitename is to be interpreted as filename/filepath
This PR will be tested in conjunction with the PRs listed below.