-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup constants in all physics #104
Comments
also samfshalcnv_run |
also gfdlmp_{init,run} |
this will also be true for the CAPS New Tiedtke physics scheme cu_ntiedtke.F90 (see PR #201) |
This applies to many other physics schemes, someone should go through all of them and clean up. Push some common ones (rainmin, ...) to physcons.F90 and pass through argument list. |
See also #245 |
…in_20210819 Update gsl/develop from main 2021/08/24
This catch-all issue for importing constants instead of passing them via the argument list doesn't help. There are many issues related to this problem on a per-scheme basis, which makes more sense. |
…owup bugfix (NCAR#104) * point to ccpp branch chsp_latlon_post * add chsp code changes from Jongil Co-authored-by: Jongil Han <[email protected]> * add landsfcmdl variable to model sfc history file meta data * add global latlon grid on write grid component, code changes from Jeffrey Whitaker Co-authored-by: Jeffrey Whitaker <[email protected]> * add chsp code changes in ccpp-physics Co-authored-by: Jongil Han <[email protected]> * remove support for legacy Intel compilers in CCPP gmake build Co-authored-by: Dom Heinzeller <[email protected]> * update ccpp physics, fix syntax error * update sflx.f in ccpp physics * CCN-IN followup bugfix Co-authored-by: Grant Firl <[email protected]> * Bugfix for GNU compiler in io/module_wrt_grid_comp.F90; bugfix in gfsphysics/physics/sfc_diff.f; updates for CCPP * merge fv3 dycore ccpp framework and physics to the latest repoes * cmeps integration changes Co-authored-by: Denise Worthen <[email protected]> * update CCPP with tsfcl change * fix timestr in module_cap_cpl.F90 * fix syntax error in ugwp_driver_v0.F * point ccpp/physics back to NCAR master Co-authored-by: Jun Wang <[email protected]> Co-authored-by: Jeffrey Whitaker <[email protected]> Co-authored-by: Jongil Han <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]> Co-authored-by: Grant Firl <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]> Co-authored-by: Denise Worthen <[email protected]>
…erosols Gf radiation update revert aerosols
samfdeepcnv_run should get its various physical constants through the argument list as per CCPP requirements.
The text was updated successfully, but these errors were encountered: