Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in gcycle if INTERNAL_FILE_NML is not defined, unused modules in radiation_surface.f #672

Closed
climbfuji opened this issue Jun 4, 2021 · 1 comment
Assignees
Labels

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Jun 4, 2021

Description

From @matusmartini:

gycle.F90

For your information, to compile I had to comment out lines around the following:
inquire (file=trim(Model%fn_nml),exist=exists)

I think the UFS/SCM don't have the problem, because the CPP macro to read the internal namelist is defined.

Fix by removing Model% and making sur that fn_nml is in the argument list.

radiation_surface.f

One other thing I noticed is that the following two modules in radiation_surface.f are not being used:

     use set_soilveg_ruc_mod,  only: set_soilveg_ruc
     use namelist_soilveg_ruc

It was throwing a compilation error, and when I removed the lines, it was not complaining anymore.

@climbfuji climbfuji added the bug label Jun 4, 2021
@climbfuji climbfuji self-assigned this Jun 4, 2021
@climbfuji climbfuji changed the title Bug in gcycle if INTERNAL_FILE_NML is not defined Bug in gcycle if INTERNAL_FILE_NML is not defined, unused modules in radiation_surface.f Jun 4, 2021
@dustinswales
Copy link
Collaborator

Resolved in #956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants