-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accumulated cleanup #956
Merged
Merged
Accumulated cleanup #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ade radiation_aerosols.f ccpp compliant
…Provided as ccpp interstitials.
… Provided as ccpp interstitials.
…Provided as ccpp interstitials.
…vided as ccpp interstitials.
… as ccpp interstitials.
dustinswales
requested review from
JongilHan66,
climbfuji,
SamuelTrahanNOAA,
grantfirl,
mzhangw,
panll,
mkavulich,
ChunxiZhang-NOAA,
tanyasmirnova,
HelinWei-NOAA,
barlage,
cenlinhe,
Qingfu-Liu,
mjiacono and
AnningCheng-NOAA
as code owners
August 30, 2022 16:50
This was referenced Sep 26, 2022
ChunxiZhang-NOAA
approved these changes
Sep 26, 2022
dustinswales
commented
Oct 27, 2022
dustinswales
pushed a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Feb 8, 2023
Accumulated cleanup
This was referenced Feb 8, 2023
This was referenced Feb 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several outstanding issues:
Along with the physparam.f cleanup in Get rid of physparam.f (but not LTP) #488, instances of physcons.f were removed for the touched subroutines, mostly the rrtmg radiation.