-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UFS-dev PR#219 #1093
Merged
Merged
UFS-dev PR#219 #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with ufs/dev
HR4 and SFS baseline update: Improve convection/radiation interaction in the GFS physics suite
grantfirl
requested review from
Qingfu-Liu,
dustinswales,
barlage,
cenlinhe,
JongilHan66 and
lisa-bengtsson
as code owners
October 16, 2024 01:50
climbfuji
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - some of the changes are from another PR that I already reviewed and got answers for my questions.
This was referenced Oct 17, 2024
Merged
Merged
Merged
Merged
grantfirl
requested review from
mkavulich
and removed request for
barlage,
cenlinhe,
JongilHan66 and
lisa-bengtsson
October 21, 2024 19:01
rhaesung
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to ufs-community#219 with changes in GFS_phys_time_vary.fv3.F90 copied to the SCM version