EMC-Flake

[YihuaWu-NOAA]

The modifications are based on Moorthi's recommendation. However, some variables in GFS_typedefs.meta file are supposed to X_water or X_wat. But, they are still in the format of X_ocean or X_ocn. For the temporary purpose, those variables used in Flake are in the format of X_ocean or X_ocn.
Detailed changes are as follow:

1. Added : flake_driv.F90, flake_driv.meta, flake.F90
2. Modified: GFS_time_vary_pre.fv3.F90 because Flake needs julian day
3. Modified: GFS_surface_composites.F90, GFS_surface_composites.meta
   added lake depth, and define the logical variable lake based on lakefraction and lakedepth
   Then, the logical variable lake is passed to flake drive and sfc_ocean.
   When lake is true, flake will be called; when lake is false, ocean model will be called
4. Modified: sfc_ocean.F, sfc_ocean.meta
   added lake, if not lake, calculation will be conducted.

[climbfuji]

Before I start reviewing this, please note that the automatic checks for ASCII encoding failed:

 Check for ASCII encoding 0s
8
##[error]Process completed with exit code 1.
1
Run ./tools/check_encoding.py
4
Traceback (most recent call last):
5
  File "./tools/check_encoding.py", line 25, in <module>
6
    raise Exception('Detected non-ascii characters in file {}, line: "{}"'.format(os.path.join(root, file), line))
7
Exception: Detected non-ascii characters in file /Users/runner/runners/2.263.0/work/ccpp-physics/ccpp-physics/physics/flake.F90, line: "!  directly recorded at ground level on Earth is -89.2 �C (-128.6 �F; 184.0 K)"
8
##[error]Process completed with exit code 1.

See https://github.com/NCAR/ccpp-physics/pull/462/checks?check_run_id=780977571.

Please fix this first and, after updating the PR, make sure that the automatic Travis tests pass (toward the end of the PR #462).

[YihuaWu-NOAA]

Before I start reviewing this, please note that the automatic checks for ASCII encoding failed:

 Check for ASCII encoding 0s
8
##[error]Process completed with exit code 1.
1
Run ./tools/check_encoding.py
4
Traceback (most recent call last):
5
  File "./tools/check_encoding.py", line 25, in <module>
6
    raise Exception('Detected non-ascii characters in file {}, line: "{}"'.format(os.path.join(root, file), line))
7
Exception: Detected non-ascii characters in file /Users/runner/runners/2.263.0/work/ccpp-physics/ccpp-physics/physics/flake.F90, line: "!  directly recorded at ground level on Earth is -89.2 �C (-128.6 �F; 184.0 K)"
8
##[error]Process completed with exit code 1.

See https://github.com/NCAR/ccpp-physics/pull/462/checks?check_run_id=780977571.

Please fix this first and, after updating the PR, make sure that the automatic Travis tests pass (toward the end of the PR #462).

They are degree c and degree F. I made the changes in my local machine, and do a push. it says the branch is update. So, I edited it online. Please try again. Thanks!

[YihuaWu-NOAA]

Hi, Dom, I already fixed this issue. They are the symbols of degree for C and F. Thanks! *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Wed, Jun 17, 2020 at 12:14 PM Dom Heinzeller ***@***.***> wrote: Before I start reviewing this, please note that the automatic checks for ASCII encoding failed: Check for ASCII encoding 0s 8 ##[error]Process completed with exit code 1. 1 Run ./tools/check_encoding.py 4 Traceback (most recent call last): 5 File "./tools/check_encoding.py", line 25, in <module> 6 raise Exception('Detected non-ascii characters in file {}, line: "{}"'.format(os.path.join(root, file), line)) 7 Exception: Detected non-ascii characters in file /Users/runner/runners/2.263.0/work/ccpp-physics/ccpp-physics/physics/flake.F90, line: "! directly recorded at ground level on Earth is -89.2 �C (-128.6 �F; 184.0 K)" 8 ##[error]Process completed with exit code 1. See https://github.com/NCAR/ccpp-physics/pull/462/checks?check_run_id=780977571 . Please fix this first and, after updating the PR, make sure that the automatic Travis tests pass (toward the end of the PR #462 <#462>). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#462 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQG5HNT4XCIYXZ7OIODRXDTVZANCNFSM4OAWQJFA> .

[climbfuji]

Hi, Dom, I already fixed this issue. They are the symbols of degree for C and F. Thanks! Yihua----------------------------------------------------Yihua Wu, Ph DI.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703
…

Thanks, the checks passed.

Is this branch now ready for code review? I don't see a date in the UFS commit queue yet.

[YihuaWu-NOAA]

Hi, Dom, I already fixed this issue. They are the symbols of degree for C and F. Thanks! _Yihua----------------------------------------------------Yihua Wu, Ph D_I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703
…

Thanks, the checks passed.

Is this branch now ready for code review? I don't see a date in the UFS commit queue yet.

Yes, I believe so. Who is going to setup the date in the UFS commit queue? Thanks!

[climbfuji]

Hi, Dom, I already fixed this issue. They are the symbols of degree for C and F. Thanks! _Yihua----------------------------------------------------Yihua Wu, Ph D_I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703
…

Thanks, the checks passed.
Is this branch now ready for code review? I don't see a date in the UFS commit queue yet.

Yes, I believe so. Who is going to setup the date in the UFS commit queue? Thanks!

Let me talk with Jun and Dusan ...

[climbfuji]

I would have preferred flake_driver instead of flake_driv throughout (it's just two letters more, and a better but unnecessary abbreviation would have been flake_drv anyway). But I leave the decision to you.

[climbfuji]

Please remove or comment out this print statement

[YihuaWu-NOAA]

Hi, Dom, Thank you very much. Sure, it would be great if you have time to change "radians" to" degree". The other issues I can fix later. Best regards *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Thu, Jul 9, 2020 at 10:39 AM Dom Heinzeller ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In physics/flake_driv.F90 <#462 (comment)>: > @@ -0,0 +1,394 @@ +!> \file flake_driv.F90 I would have preferred flake_driver instead of flake_driv throughout (it's just two letters more, and a better but unnecessary abbreviation would have been flake_drv anyway). But I leave the decision to you. ------------------------------ In physics/flake_driv.F90 <#462 (comment)>: > + lake_depth_max = 60.0 + ipr = min(im,10) + +! --- ... set flag for lake points + + do i = 1, im + flag(i) = (wet(i) .and. flag_iter(i)) + enddo + + Kbar=3.5 + DelK=3.0 + + do i = 1, im + if (flag(i)) then + if( lake(i) ) then + print*,'lake depth=',lakedepth Please remove or comment out this print statement ------------------------------ In physics/flake_driv.F90 <#462 (comment)>: > + flag(i) = (wet(i) .and. flag_iter(i)) + enddo + + Kbar=3.5 + DelK=3.0 + + do i = 1, im + if (flag(i)) then + if( lake(i) ) then + print*,'lake depth=',lakedepth + T_ice(i) = 273.15 + T_snow(i) = 273.15 + fetch(i) = 2.0E+03 + C_T(i) = 0.50 + + dxlat = 57.29578*abs(xlat(i)) This could be automated with CCPP (use the correct metadata and add the conversion if not yet present to ccpp-framework). Not for this PR, but in a future improvement. ------------------------------ In physics/flake_driv.meta <#462 (comment)>: > + type = real + kind = kind_phys + intent = in + optional = F +[lake] + standard_name = flag_nonzero_lake_surface_fraction + long_name = flag indicating presence of some lake surface area fraction + units = flag + dimensions = (horizontal_dimension) + type = logical + intent = in + optional = F +[xlat] + standard_name = latitude + long_name = latitude + units = radians This would be the place to specify "degrees" instead of "radians" and then add the corresponding conversion to ccpp-framework. Let me know if you want to explore this as part of the PR and I will help with any necessary ccpp-framework changes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#462 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQFQQ6EXR3QDCTLQFITR2XJCBANCNFSM4OAWQJFA> .

[climbfuji]

Please comment out the print statement in physics/flake_driv.F90 line 216.

Ignore my comment about automating the unit conversion.

[YihuaWu-NOAA]

Thanks, Dom, I already commented out that line on line. *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Thu, Jul 9, 2020 at 11:38 AM Dom Heinzeller ***@***.***> wrote: ***@***.**** commented on this pull request. Please comment out the print statement in physics/flake_driv.F90 line 216. Ignore my comment about automating the unit conversion. ------------------------------ In physics/flake_driv.meta <#462 (comment)>: > + type = real + kind = kind_phys + intent = in + optional = F +[lake] + standard_name = flag_nonzero_lake_surface_fraction + long_name = flag indicating presence of some lake surface area fraction + units = flag + dimensions = (horizontal_dimension) + type = logical + intent = in + optional = F +[xlat] + standard_name = latitude + long_name = latitude + units = radians Update. I see that you use xlat in radians in other parts of the subroutine, so please ignore my previous comment about automating this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#462 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQDHXHNQJKLAXVORHMDR2XQADANCNFSM4OAWQJFA> .

[climbfuji]

Per @YihuaWu-NOAA I am closing this PR, the correct one to use is #471 .