Wrapper PR for #781 (New Thompson cloud fraction) and #800 (Remove Laurie from CODEOWNERS)

[climbfuji]

UPDATE 2021/12/09 The changes from PR #789 (Cloud cover change for Xu Randall) were removed, since they caused crashes for all runs with Thompson and the GSL physics. This PR now contains only the changes from #781 (New Thompson cloud fraction) and #800 (Remove Laurie from CODEOWNERS), and a change in CMakeLists.txt to compile one file in rte-rrtmgp with -O1 in PROD mode to address an apparent compiler bug with newer Intel compilers for RRTMGP.

Associated PRs:

• Wrapper PR for #781 (New Thompson cloud fraction) and #800 (Remove Laurie from CODEOWNERS) #795
• New Thompson cloud fraction (updated subroutine cal_cldfra3) NOAA-EMC/fv3atm#432
• New Thompson cloud fraction (updated subroutine cal_cldfra3) ufs-community/ufs-weather-model#929

For regression testing, see ufs-community/ufs-weather-model#929

[RuiyuSun]

Dom, I checked my changes are integrated correctly into Greg's branch. Ruiyu

…

On Mon, Dec 6, 2021 at 10:12 AM Dom Heinzeller ***@***.***> wrote: DRAFT @RuiyuSun <https://github.com/RuiyuSun> I merged your branch RuiyuSun:cloud_cover_xr into gthompsnWRF:new_thompson_cloud_fraction. There were merge conflicts in two files, physics/GFS_rrtmg_pre.F90 and physics/radiation_clouds.f. The conflicts in physics/GFS_rrtmg_pre.F90 were straightforward to resolve, but the ones in physics/radiation_clouds.f not. Can you please check this PR carefully and make sure that I integrated your changes correctly into Greg's branch? You can check out all three versions like this: # Greg's branch git clone -b new_thompson_cloud_fraction https://github.com/gthompsnWRF/ccpp-physics ccpp-physics-greg git clone -b cloud_cover_xr https://github.com/RuiyuSun/ccpp-physics ccpp-physics-ruiyu git clone -b greg_new_thompson_cloud_fraction_with_ruiyu_cloud_cover_change_xu_randall https://github.com/climbfuji/ccpp-physics ccpp-physics-greg-and-ruiyu-combined Thanks very much! ------------------------------ You can view, comment on, or merge this pull request online at: #795 Commit Summary - 29db559 <29db559> added a new cloud fraction scheme (actually upgraded cal_cldfra3) designed with Thompson-MP for GFSv17-prototype8 - 052145c <052145c> correct a dumb mistake - 8da0705 <8da0705> make icloud=3 call cldfra3 compatible with updated subroutine - 3787899 <3787899> bug fix lwp_ex and iwp_ex inside progcld6; factor of 1000 - f9c785f <f9c785f> Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD - 4742485 <4742485> Fix compilation error with gfortran in physics/radiation_clouds.f - cba377d <cba377d> Merge pull request #1 from climbfuji/new_thompson_cloud_fraction_update_from_main_20211119 - 30ae919 <30ae919> Avoid dividing by zero in physics/GFS_rrtmg_post.F90 - 74cae0c <74cae0c> Move total albedo to right place in physics/GFS_rrtmg_post.meta, make intent(inout) - fe6677f <fe6677f> minor adjustments to reduce coverage of partly cloudy conditions - 25d28e7 <25d28e7> Merge branch 'new_thompson_cloud_fraction' of https://github.com/gthompsnWRF/ccpp-physics into new_thompson_cloud_fraction - b4d7ab0 <b4d7ab0> Use correct vertical dimension for several cloud arrays in physics/GFS_rrtmg_post.meta and physics/GFS_rrtmg_pre.meta - aba5331 <aba5331> Merge branch 'new_thompson_cloud_fraction' of https://github.com/gthompsnWRF/ccpp-physics into new_thompson_cloud_fraction_update_from_main_20211119 - 24d850d <24d850d> Merge pull request #2 from climbfuji/new_thompson_cloud_fraction_update_from_main_20211122 - 6f91aea <6f91aea> silly stray comment/exclamation point - 211a413 <211a413> fix a few comment lines per review of pull request 781 - 0a54eec <0a54eec> per discussions with Ruiyu, increasing min snow and graupel size seems advantageous - 1120779 <1120779> tiny adjustment of indent/format consistency - 7e119fc <7e119fc> re-use icloud=3 option for progcld_thompson - bc8c26d <bc8c26d> per review by climbfuji, make suggested changes - 2b2e3b1 <2b2e3b1> disallow rain in Thompson to be used in radiation scheme; also set fractional cloudy LWP and IWP inside progcld6 - 7d0d736 <7d0d736> minor rearrangement of cloud fraction with very low mixing ratios - cd00e16 <cd00e16> Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD - f1dd327 <f1dd327> Merge pull request #4 from climbfuji/greg_new_thompson_cloud_fraction_update_from_main_20211129 - 473eaf6 <473eaf6> cloud cover change associated with xu_randall - a14bfb5 <a14bfb5> Merge branch 'cloud_cover_xr' of https://github.com/ruiyusun/ccpp-physics into greg_new_thompson_cloud_fraction_with_ruiyu_cloud_cover_change_xu_randall File Changes (6 files <https://github.com/NCAR/ccpp-physics/pull/795/files>) - *M* physics/GFS_rrtmg_post.F90 <https://github.com/NCAR/ccpp-physics/pull/795/files#diff-486c0deaab69e644d6c7610cadb2bb08373c1d19c3ec5c2f7f5aea4edfeaacdb> (9) - *M* physics/GFS_rrtmg_post.meta <https://github.com/NCAR/ccpp-physics/pull/795/files#diff-84ffa63e53cab805802252725ec6d07cadb73f244579059d4f99dea835ab4735> (10) - *M* physics/GFS_rrtmg_pre.F90 <https://github.com/NCAR/ccpp-physics/pull/795/files#diff-135feb492e7ec0ea9d140b82431a8b8eda48acb4eab4ed783ca819e933476475> (159) - *M* physics/GFS_rrtmg_pre.meta <https://github.com/NCAR/ccpp-physics/pull/795/files#diff-3579826173828ced095cc5d5a7a28b2e5d80f0d48dcdb2863f6eab0079564ead> (42) - *M* physics/module_mp_thompson.F90 <https://github.com/NCAR/ccpp-physics/pull/795/files#diff-5bf86fc964926b7850d0009e09c945188443c845ef3f734c47a0d2abf65b0e75> (10) - *M* physics/radiation_clouds.f <https://github.com/NCAR/ccpp-physics/pull/795/files#diff-18590ff2aff35744369b791bfdbd79779a40b6463d051c2cf4d9bdd51b0dd2c8> (973) Patch Links: - https://github.com/NCAR/ccpp-physics/pull/795.patch - https://github.com/NCAR/ccpp-physics/pull/795.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#795>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFOCLBWIYQYLY5VDR324GDUPTHEPANCNFSM5JO3KSPQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Ruiyu Sun, PhD *IMSG* at NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2097 College Park, MD 20740 ***@***.*** ***@***.***> 301-683-3787

[climbfuji]

Dom, I checked my changes are integrated correctly into Greg's branch. Ruiyu
…

Thanks very much for checking, Ruiyu!

[grantfirl]

The wrapper of the two PRs is approved since the content is identical to previously-approved PRs (save for one compilation bugfix added by @climbfuji).

[ericaligo-NOAA]

What is this change for? Going from
pnr_wau(k) = prr_wau(k) / (am_rnu_c200.D0rD0rD0r)
to
pnr_wau(k) = prr_wau(k) / (am_rnu_c10.D0rD0rD0r)

[climbfuji]

What is this change for? Going from
pnr_wau(k) = prr_wau(k) / (am_r_nu_c_200._D0r_D0r_D0r) to pnr_wau(k) = prr_wau(k) / (am_r_nu_c_10._D0r_D0r_D0r)

I unfortunately cannot answer this question, it is from PR #781 by @gthompsnWRF - not sure when greg will be back from leave.

[ericaligo-NOAA]

I'll approve these changes. Any bugs related to the change in the Thompson scheme can be fixed later.

[gthompsnJCSDA]

What is this change for? Going from pnr_wau(k) = prr_wau(k) / (am_r_nu_c_200._D0r_D0r_D0r) to pnr_wau(k) = prr_wau(k) / (am_r_nu_c_10._D0r_D0r_D0r)

This change is needed. It relates to the number tendency term for production of rain from "autoconversion." In recent work I've done simulating atmospheric river events (west coast USA), the conversion of cloud water to rain (number concentration), this "tuning parameter" was found to have a strong influence on initial size of rain drops. Comparisons to disdrometer and radar data led to this constant being changed from 200 to 10 to reduce overall the size of initial rain drops (more like small drizzle) with lower reflectivity.

[yangfanglin]

I'd recommend to have this PR approved and merged to the develop branch at the earliest time possible so that we can start to run one of the upcoming mini UFS Prototype 8 with Thompson MP included. As we have all agreed, Xu&Randall cloud cover will be used while we keep improving cldfra3. Greg, you can create a new PR for further improvement of the model performance with cldfra3. Is this a reasonable approach ?

[yangfanglin]

Dom, could you please add Anning and Moorthi as the reviewers as well ? Thanks

[climbfuji]

Dom, could you please add Anning and Moorthi as the reviewers as well ? Thanks

I added Moorthi, Anning still didn't accept the invite it looks like. Yes, this PR is scheduled next, after the RRTMGP PR.

[AnningCheng-NOAA]

Approved. A comment: most of the changes are to increase the cloud fraction, however, many of them might be reversed when The new Thompson cloud fraction is used because the global mean cloud fraction from this approach is too large for all levels.