Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing redundancy in assigning directories... #12

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

mariajmolina
Copy link
Contributor

Currently, the directories for save_path, error file name (batch job script), and output file name (batch job script) have to be updated for different echo/optuna studies, creating possible workflow failures if a minor typo is made. This update allows us to just set the error file and output file names to something like out and allow echo to append it to the already defined save_path.

Merge pull request NCAR#11 from mariajmolina/main
Currently, the directories for save_path, error file (batch job script), and output file (batch job script) have to be updated for different echo/optuna studies, creating possible workflow failures  if minor typo is made. This update allows us to just set the error file and output file names to something like "out" and allow echo to append it to the already defined save_path.
Copy link
Collaborator

@djgagne djgagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Merging.

@djgagne djgagne merged commit 5bcb700 into NCAR:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants