-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.9 Support #599
Conversation
The current PR checks are expecting the three remaining tests for Python 3.9 across platforms, but they are no longer being generating, so those three unfinished tests can be ignored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
I'll go turn off the required checks for 3.9 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the minor release notes item!
I am curious if we have any pending or planned work that's not 3.9 compatible.
If not, I might have a slight preference for holding off a little bit on this (at least until the end of the iteration). It looks like xarray hasn't dropped 3.9 quite yet and our examples gallery can't move to 3.12 yet because of wrf-python.
@@ -11,8 +11,10 @@ Upcoming release | |||
|
|||
Internal Changes | |||
^^^^^^^^^^^^^^^^ | |||
* Drop Python 3.9 Support by `Cora Schneck`_ in (:pr:`599`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably want this in a different category. Maybe "Compatibility Notes" or "Breaking Changes"? @anissa111, I've been meaning to ask - is there a list of categories you use for release notes?
* remove 3.9 support and workflows * update release-notes.rst
This reverts commit cc73dc1.
PR Summary
Closes #553
PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecatedprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.