namelist and configuration of HWRF physics test #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhangw
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
This was referenced May 12, 2020
climbfuji
requested changes
May 20, 2020
There was a problem hiding this comment.
These namelists, run scripts and other configuration files need to be cleaned up. Using variables set by the regression tests in tests/tests/ or by default in tests/default_vars.sh, many of these files can be combined (possibly even with existing ones). See how this is done for the various GSD tests in tests/tests/, which mostly use tests/fv3_conv/ccpp_gsd_run.IN and parm/ccpp_gsd.nml.IN.
|
Thanks for your efforts! I will look into it.
Man
… On May 20, 2020, at 4:46 PM, Dom Heinzeller ***@***.***> wrote:
@climbfuji requested changes on this pull request.
These namelists, run scripts and other configuration files need to be cleaned up. Using variables set by the regression tests in tests/tests/ or by default in tests/default_vars.sh, many of these files can be combined (possibly even with existing ones). See how this is done for the various GSD tests in tests/tests/, which mostly use tests/fv3_conv/ccpp_gsd_run.IN and parm/ccpp_gsd.nml.IN.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#42 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2TWNRE3F5C4EA4RL7DRSRMUZANCNFSM4MK5N4AQ>.
|
|
@mzhangw Please confirm that this PR can be closed. Thanks! |
|
This PR can be deleted |
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/ufs-weather-model
that referenced
this pull request
Nov 10, 2020
Move RUC LSM soil variables initialization to lsm_ruc_init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the NML and configuration of HWRF physics test RTs, which includes the following RTs:
-fv3_ccpp_regional_c768_hafs
-fv3_ccpp_regional_c768_hafs_nogwdps
-fv3_ccpp_regional_c768_hwrf
-fv3_ccpp_regional_c768_hwrf_nogwdps
The associated PR is
NCAR/fv3atm#44
NCAR/ccpp-physics#450
It passed all RTs on hera