Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOC floats at top of page in portals sometimes #2195

Closed
robyngit opened this issue Sep 13, 2023 · 0 comments · Fixed by #2213
Closed

TOC floats at top of page in portals sometimes #2195

robyngit opened this issue Sep 13, 2023 · 0 comments · Fixed by #2213
Assignees
@robyngit
Labels
bug
Milestone
2.27.0

Comments

@robyngit
Copy link
Member

See this portal: https://search.dataone.org/portals/tnc_dangermond/Submit-Data. On the Submit Data page, the table of contents floats at the top of the page rather than the top of the markdown content.

Screenshot 2023-09-13 at 13 03 48

This can be resolved by adding some padding to the bottom of the markdown element.

markdown-section

We should set a min height on these markdown sections, or otherwise fix the TOC to be affixed to the top of the content section, not the top of the page.
@robyngit robyngit added the bug label Sep 13, 2023
@robyngit robyngit added this to the 2.27.0 milestone Sep 13, 2023
@robyngit robyngit self-assigned this Sep 21, 2023
robyngit added a commit that referenced this issue Oct 26, 2023
@robyngit
Prevent weird TOC placement in portals
acc05af 
- Add min height to markdown sections with portals
- Also rename methods from postRender to what they do, because backbone calls these methods automatically even though this isn't documented!

fixes #2195
@robyngit robyngit mentioned this issue Oct 26, 2023
Merged
@robyngit robyngit linked a pull request Oct 26, 2023 that will close this issue
Prevent weird TOC placement in portals #2213
Merged
robyngit added a commit that referenced this issue Nov 1, 2023
@robyngit
Prevent weird TOC placement in portals
703883e 
- Add min height to markdown sections with portals
- Also rename methods from postRender to what they do, because backbone calls these methods automatically even though this isn't documented!

fixes #2195
@robyngit robyngit mentioned this issue Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
bug
Projects
None yet
Milestone
2.27.0
Development

Successfully merging a pull request may close this issue.

Prevent weird TOC placement in portals NCEAS/metacatui
1 participant
@robyngit