Use Microfot.Data.SqlClient instead of System.Data.SqlClient #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent` This commit includes a significant change where the `System.Data.SqlClient` package has been replaced with `Microsoft.Data.SqlClient` across multiple files. This is a breaking change and is highlighted in the `Changelog.md` file. The `Microsoft.Data.SqlClient` package is the latest and recommended data provider for SQL Server. The connection string for `NEventStore.MsSql` in the `README.md` file has been updated. The `.editorconfig` file now includes new rules for code formatting and style. The `NEventStore.Persistence.Sql.nuspec` file and several project files have been updated to replace the `System.Data.SqlClient` dependency with `Microsoft.Data.SqlClient`. Several test files have been updated to use `Microsoft.Data.SqlClient` and their code formatting has been updated. The `using System.Data.SqlClient;` and `using Microsoft.Data.SqlClient;` statements have been removed from the `MsSqlDialect.cs` file, and the `using System;` statement has been added. The `#if NET462` preprocessor directive and its associated code have been removed. The `SqlException` class from the `System.Data.SqlClient` namespace has been replaced with the `SqlException` class from the `Microsoft.Data.SqlClient` namespace in the `IsDuplicate` method. Lastly, the `MsSqlDialect` and `MsSql2005Dialect` classes have been restructured but their functionality remains the same.
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR superseeds PR #43 .
It incorporates original commits and changes a couple more things: