fix(module:menu): fix submenu ExpressionChangedAfterItHasBeenCheckedE…

…rror close #367
NG-ZORRO · Sep 23, 2017 · 3e1cbeb · 3e1cbeb
1 parent 1a997c2
commit 3e1cbeb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/components/menu/nz-menu.component.ts b/src/components/menu/nz-menu.component.ts
@@ -35,10 +35,12 @@ export class NzMenuComponent implements OnChanges, AfterViewInit {
   @Input() nzMode: NzMode = 'vertical';
   @Input() nzTheme: 'light' | 'dark' = 'light';
   @Input() nzClickActive = true;
+
   @Input()
   get nzInlineCollapsed(): boolean {
     return this._nzInlineCollapsed;
   }
+
   set nzInlineCollapsed(state: boolean) {
     this._nzInlineCollapsed = state;
     if (!this.isInit) {
@@ -143,7 +145,7 @@ export class NzMenuComponent implements OnChanges, AfterViewInit {
   }
 
   reductionSubMenus() {
-    this._subMenusOpenIndex.forEach(i => this.subMenus[i].nzOpen = true);
+    this._subMenusOpenIndex.forEach(i => this.subMenus[ i ].nzOpen = true);
     this._subMenusOpenIndex = [];
   }
 
@@ -155,4 +157,10 @@ export class NzMenuComponent implements OnChanges, AfterViewInit {
       this.subMenus.forEach(subMenu => subMenu.isInDropDown = value);
     });
   }
+
+  setHasSubMenu(value: boolean) {
+    setTimeout(_ => {
+      this.hasSubMenu = value;
+    })
+  }
 }
diff --git a/src/components/menu/nz-submenu.component.ts b/src/components/menu/nz-submenu.component.ts
@@ -140,7 +140,7 @@ export class NzSubMenuComponent implements OnInit, OnDestroy, AfterViewInit {
 
 
   constructor(public nzMenuComponent: NzMenuComponent, public cd: ChangeDetectorRef) {
-    this.nzMenuComponent.hasSubMenu = true;
+    this.nzMenuComponent.setHasSubMenu(true);
     this.nzMenuComponent.subMenus.push(this);
   }