Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tree-select] feature: support treeNodeLabelProp from react tree-select equivalent #1823

Closed
murraybauer opened this issue Jul 13, 2018 · 1 comment
Closed

[tree-select] feature: support treeNodeLabelProp from react tree-select equivalent #1823

murraybauer opened this issue Jul 13, 2018 · 1 comment
Assignees
@hsuanxyz
Labels
🌈 Feature Request

Comments

@murraybauer
Copy link

murraybauer commented Jul 13, 2018 •
edited
Loading

Version

1.1.1

Environment

Reproduction link

https://codesandbox.io/s/z2qp7rk73x

Steps to reproduce

Please port the [treeNodeLabelProp] property from the react tree-select equivalent so it's possible to set an alternate display name for selected tags so it doesn't have to match the label.

Really important for long trees as displaying only the name of a deeply nested leaf node provides no context to the user.

What is expected?

Codesandbox for react tree-select showing desired custom text

image

What is actually happening?

Angular example with no [treeNodeLabelProp] property so tags use label field only

image
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Jul 16, 2018
@hsuanxyz
feta(module:tree-select): support custom display in the trigger
31b0a6e 
close NG-ZORRO#1823
@hsuanxyz hsuanxyz mentioned this issue Jul 16, 2018
Merged
3 tasks
@hsuanxyz hsuanxyz self-assigned this Jul 16, 2018
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Jul 17, 2018
@hsuanxyz
feta(module:tree-select): support custom display in the trigger
9df27a6 
close NG-ZORRO#1823
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Jul 19, 2018
@hsuanxyz
feta(module:tree-select): support custom display in the trigger
f74daa8 
close NG-ZORRO#1823
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Jul 22, 2018
@hsuanxyz
feat(module:tree-select): support custom display in the trigger (NG-Z…
526cb05 
…ORRO#1832)

close NG-ZORRO#1823
vthinkxie pushed a commit that referenced this issue Jul 22, 2018
@hsuanxyz
feat(module:tree-select): support custom display in the trigger (#1832)
1cc3646 
close #1823
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this issue Aug 27, 2018
@hsuanxyz @wenqi73
feat(module:tree-select): support custom display in the trigger (NG-Z…
0065c7b 
…ORRO#1832)

close NG-ZORRO#1823
@lock
Copy link

lock bot commented Jul 22, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2019
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz
feat(module:tree-select): support custom display in the trigger (NG-Z…
fc8add5 
…ORRO#1832)

close NG-ZORRO#1823
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hsuanxyz hsuanxyz

Labels
🌈 Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murraybauer @hsuanxyz