Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope that Message component could support custom icon #3123

Closed
ishowman opened this issue Mar 20, 2019 · 2 comments
Closed

Hope that Message component could support custom icon #3123

ishowman opened this issue Mar 20, 2019 · 2 comments
Assignees

Comments

@ishowman
Copy link

ishowman commented Mar 20, 2019

What problem does this feature solve?

There're some case that the default icons of Message component is not suitable for our products, it's necessary to add an api for developer to use custom icons.

What does the proposed API look like?

I hope that add an new api for Message component like below:

this.message.success('Loading finished', 
  { nzCustomIcon: 'icon template ref or html like <i class="fas fa-angle-left"></i>' }
)

Maybe there are better solutions, hoping to get reply from you. Thanks!

@wzhudev
Copy link
Member

wzhudev commented Mar 20, 2019

@ishowman You can track this PR #3102. You would be able to put an icon in the template and use messageService.create('', templateWithIcon, options) to achieve that.

@wzhudev
Copy link
Member

wzhudev commented Mar 21, 2019

Closed by #3102.

@wzhudev wzhudev closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants