Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:message): support template #3102

Merged
merged 5 commits into from
Mar 20, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 15, 2019

close #3081

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

A user cannot pass a TemplateRef to content. They have to use inline HTML.

Issue Number: #3081

What is the new behavior?

Now a user can pass a TemplateRef<void> to content.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #3102 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
+ Coverage   97.32%   97.32%   +<.01%     
==========================================
  Files         550      550              
  Lines       11526    11527       +1     
  Branches      824      824              
==========================================
+ Hits        11218    11219       +1     
  Misses        199      199              
  Partials      109      109
Impacted Files Coverage Δ
components/message/nz-message.service.ts 97.91% <100%> (ø) ⬆️
components/message/nz-message.module.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2841a2f...3029d03. Read the comment docs.

@netlify
Copy link

netlify bot commented Mar 15, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 3029d03

https://deploy-preview-3102--ng-zorro-master.netlify.com

})
export class DemoAppComponent {}
export class DemoAppComponent {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

解一下冲突

@hsuanxyz hsuanxyz merged commit d3f6655 into NG-ZORRO:master Mar 20, 2019
@wzhudev wzhudev deleted the message-template branch March 20, 2019 09:01
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:message): support template

* docs: update content type

* fix: createMessage

* fix: lint

* fix: test

close NG-ZORRO#3081
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:message): support template

* docs: update content type

* fix: createMessage

* fix: lint

* fix: test

close NG-ZORRO#3081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message module content property should support type TemplateRef param
2 participants