-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nzMatchRouter behaviour #3736
Comments
they are working the same way |
Hello @Svetomechc. Please provide a online reproduction by forking this link https://stackblitz.com/edit/ng-zorro-antd-start or a minimal GitHub repository. 你好 @Svetomechc, 我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击 此处 创建一个 stackblitz 或者提供一个最小化的 GitHub 仓库 |
It is hard for me to reproduce outside my project as it uses custom dynamic menu building from routes meta info. |
@vthinkxie okay, I did it: https://stackblitz.com/edit/ng-zorro-antd-start-ipf8qe?embed=1&file=src/app/app.component.html
You'll see differences between nzMatchRouter and routerLinkActive #rla="routerLinkActive" [nzSelected]="rla.isActive" immediately. Sadly, the former behaves worse than the latter :( |
@vthinkxie is this reproduction ok? |
@Svetomechc yes, fixed in #3785 |
My pleasure (: |
8.0.3 @Svetomechc |
Cool. |
What problem does this feature solve?
I expected nzMatchRouter directive to be the same as writing routerLinkActive #rla="routerLinkActive" [nzSelected]="rla.isActive". It is not.
What does the proposed API look like?
Please, make nzMatchRouter behave exactly like routerLinkActive #rla="routerLinkActive" [nzSelected]="rla.isActive" does.
The text was updated successfully, but these errors were encountered: