Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:breadcrumb): add nzRouteLabel property #4167

Merged
merged 2 commits into from
Sep 30, 2019
Merged

feat(module:breadcrumb): add nzRouteLabel property #4167

merged 2 commits into from
Sep 30, 2019

Conversation

CK110
Copy link
Member

@CK110 CK110 commented Sep 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3775

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Sep 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit bb8a310

https://deploy-preview-4167--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #4167 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4167      +/-   ##
==========================================
- Coverage   92.27%   92.26%   -0.01%     
==========================================
  Files         517      517              
  Lines       10961    10961              
  Branches     1985     1985              
==========================================
- Hits        10114    10113       -1     
  Misses        422      422              
- Partials      425      426       +1
Impacted Files Coverage Δ
components/breadcrumb/nz-breadcrumb.component.ts 89.74% <100%> (ø) ⬆️
components/select/nz-option-container.component.ts 93.75% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1e496...bb8a310. Read the comment docs.

@wenqi73 wenqi73 requested review from wzhudev and removed request for wenqi73 September 16, 2019 11:29
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some patches are required.

components/breadcrumb/doc/index.en-US.md Outdated Show resolved Hide resolved
components/breadcrumb/doc/index.zh-CN.md Outdated Show resolved Hide resolved
@CK110 CK110 changed the title feat(module:breadcrumb): add nzRouteDataBreadcrumbLabel property feat(module:breadcrumb): add nzRouteLabel property Sep 17, 2019
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev
Copy link
Member

wzhudev commented Sep 17, 2019

@CK110 Thank you! This would be merged in the next minor version.

@wzhudev wzhudev merged commit 34a8b0a into NG-ZORRO:master Sep 30, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:breadcrumb): add `nzRouteDataBreadcrumbLabel` property

* feat(module:breadcrumb): change property to `nzRouteLabel`
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:breadcrumb): add `nzRouteDataBreadcrumbLabel` property

* feat(module:breadcrumb): change property to `nzRouteLabel`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants