Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree 默认选择的BUG问题 nzCheckedKeys #4472

Closed
victory-wu opened this issue Nov 25, 2019 · 2 comments · Fixed by #6161
Closed

tree 默认选择的BUG问题 nzCheckedKeys #4472

victory-wu opened this issue Nov 25, 2019 · 2 comments · Fixed by #6161
Assignees
@simplejason
Labels
Component: Tree
Milestone
backlog

Comments

@victory-wu
Copy link

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-i1h1hu?file=src/app/app.component.ts

Steps to reproduce

先设置nzCheckedKeys， 而后 nzData就会出现无法复选的问题

What is expected?

nzData nzCheckedKeys 使用无需分先后顺序，延迟加载体验不好

What is actually happening?

nzCheckedKeys 同时附加数据
nzData 同时附加数据

如果 nzCheckedKeys 速度比nzDATA快 就会导致无法成功勾选结果

Environment Info
ng-zorro-antd 8.5.1
Browser CHROME 版本 78.0.3904.70（正式版本） （64 位）

比如编辑权限时候， 所有权限列表，和已勾选的权限，需要同时加载，不应该分先后加载。节约加载时间。
@zorro-bot
Copy link

zorro-bot bot commented Nov 25, 2019

Translation of this issue:

tree selected by default BUG problem nzCheckedKeys

Reproduction link

[Https://stackblitz.com/edit/ng-zorro-antd-start-i1h1hu?file=src/app/app.component.ts](https://stackblitz.com/edit/ng-zorro-antd- start-i1h1hu? file = src / app / app.component.ts)

Steps to reproduce

First set nzCheckedKeys, then there will not be a check nzData problem

What is expected?

nzData nzCheckedKeys use without sub-order, lazy loading experience is not good

What is actually happening?

nzCheckedKeys while additional data
nzData while additional data

If nzCheckedKeys will result in faster than nzDATA unable to successfully check results

Environment Info
Ng-zorro-antd 8.5.1
Browser CHROME version 78.0.3904.70 (official version) (64)

For example, when editing permissions, all permissions list, and checked the permissions need to be loaded, points should not have loaded. Save loading time.

@simplejason
Copy link
Member

暂时设计并不会去触发重新渲染，可以通过重新赋值方式 https://stackblitz.com/edit/ng-zorro-antd-start-mgp3ia?file=src/app/app.component.ts

@phoenix110 phoenix110 mentioned this issue Jan 1, 2020
Closed
@hsuanxyz hsuanxyz added this to the backlog milestone Oct 22, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
5ed97f7 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
@hsuanxyz hsuanxyz mentioned this issue Dec 8, 2020
Merged
3 tasks
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
51fa956 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
c98aff6 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
c7d8d2d 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
87bd33c 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
6b91a21 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
13a550d 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 9, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
171a7bb 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 14, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
7bc5156 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 16, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
3afe868 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit that referenced this issue Dec 16, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component (#6161)
05d58de 
close #5976, close #5809, close #5739, close #5736, close #5519, close #5446, close #5152, close #4694, close #4472, close #3832, close #2785, close #2744, close #6199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simplejason simplejason

Labels
Component: Tree
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

feat(module:tree-view): add tree-view component hsuanxyz/ng-zorro-antd
3 participants
@victory-wu @simplejason @hsuanxyz