Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nz-tabset[nzLinkRouter] breaks nz-tab[nzDisabled] #5543

Closed
Airblader opened this issue Jul 10, 2020 · 0 comments · Fixed by #5759
Closed

nz-tabset[nzLinkRouter] breaks nz-tab[nzDisabled] #5543

Airblader opened this issue Jul 10, 2020 · 0 comments · Fixed by #5759
Assignees
@vthinkxie @NearZXH
Labels
🐛 Bug Component: Tabs

Comments

@Airblader
Copy link
Collaborator

Reproduction link

https://stackblitz.com/edit/angular-auqmtj

Steps to reproduce

  1. Use nzLinkRouter for nz-tabset.
  2. Add a tab with nzDisabled and a[nz-tab-link]

What is expected?

The tab should both not be clickable and appear disabled like disabled tabs when not using nzLinkRouter.

What is actually happening?

The tab does not appear visually disabled and is also clickable as if it was a normal enabled tab.

(Note that even with nzLinkRouter when using span[nz-tab-link] instead of a[nz-tab-link] the behavior is correct.)

Environment Info
ng-zorro-antd 9.1.2
Browser Google Chrome Version 83.0.4103.116 (Official Build) (64-bit)
@vthinkxie vthinkxie self-assigned this Jul 10, 2020
@weekly-digest weekly-digest bot mentioned this issue Jul 12, 2020
Closed
@danranVm danranVm mentioned this issue Jul 12, 2020
Closed
3 tasks
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Sep 10, 2020
@hsuanxyz
fix(module:tabs): tab-link cannot be disabled
8a5ce8f 
close NG-ZORRO#5549, close NG-ZORRO#5543
@hsuanxyz hsuanxyz mentioned this issue Sep 10, 2020
Merged
3 tasks
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Sep 10, 2020
@hsuanxyz
fix(module:tabs): tab-link cannot be disabled
1902135 
close NG-ZORRO#5549, close NG-ZORRO#5543
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Sep 10, 2020
@hsuanxyz
fix(module:tabs): tab-link cannot be disabled
5f42d51 
close NG-ZORRO#5549, close NG-ZORRO#5543
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Sep 10, 2020
@hsuanxyz
fix(module:tabs): tab-link cannot be disabled
9216a9f 
close NG-ZORRO#5549, close NG-ZORRO#5543
hsuanxyz added a commit that referenced this issue Sep 10, 2020
@hsuanxyz
fix(module:tabs): tab-link cannot be disabled (#5759)
1afabd4 
close #5549, close #5543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

@NearZXH NearZXH

Labels
🐛 Bug Component: Tabs
Projects
None yet
Milestone
No milestone
3 participants
@vthinkxie @Airblader and others