Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nz-spin does not respect delay on start #5928

Closed
Airblader opened this issue Oct 15, 2020 · 0 comments · Fixed by #5930
Closed

nz-spin does not respect delay on start #5928

Airblader opened this issue Oct 15, 2020 · 0 comments · Fixed by #5930
Assignees

Comments

@Airblader
Copy link
Collaborator

Reproduction link

https://stackblitz.com/edit/angular-lrunm3?file=src/app/app.component.ts

Steps to reproduce

Just open the reproduction.

What is expected?

The spinner should only start after 5s.

What is actually happening?

The spinner starts immediately.

Environment Info
ng-zorro-antd 10.0.1
Browser Chrome

It seems that when nz-spin is initially rendered the delay is not respected. It does work on subsequent changes to the input.

Airblader added a commit to Airblader/ng-zorro-antd that referenced this issue Oct 15, 2020
Airblader added a commit to Airblader/ng-zorro-antd that referenced this issue Oct 15, 2020
vthinkxie pushed a commit that referenced this issue Oct 16, 2020
* docs: remove useless CSS

* fix(module:spin): use delay only to activate spinner

This also cleans up the rxjs in this component which would actually create
a memory leak over time if the delay input changes a lot (which is very
hypothetical).

fixes #5926

* fix(module:spin): respect delay on init

fixes #5928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants