Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb <a></a> tag's style is overiding breadcrumb last-child's style #5942

Closed
duongleh opened this issue Oct 18, 2020 · 3 comments · Fixed by #5994
Closed

Breadcrumb <a></a> tag's style is overiding breadcrumb last-child's style #5942

duongleh opened this issue Oct 18, 2020 · 3 comments · Fixed by #5994

Comments

@duongleh
Copy link
Contributor

Reproduction link

https://stackblitz.com/edit/angular-yokrh1?file=src/app/app.component.ts

Steps to reproduce

Add <a></a> tag to the last breadcrumb-item.

What is expected?

The last breadcrumb item's color should be different from the others.

What is actually happening?

The last breadcrumb item's color is the same as the others.

Environment Info
ng-zorro-antd 9.3.0
Browser Chrome 86
@wenqi73
Copy link
Member

wenqi73 commented Oct 23, 2020

As our DOM is not the same with ant-design, the less in https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/components/breadcrumb/style/index.less#L24-L29 is not work, need additional less in patch.less.

@zorro-bot
Copy link

zorro-bot bot commented Oct 23, 2020

Hello @duongle26. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @duongle26, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

@wenqi73 wenqi73 added this to the backlog milestone Oct 23, 2020
@stygian-desolator
Copy link
Collaborator

Hello @wenqi73 , I would like to fix this issue, but I have some doubts during the repair process, such as whether the a element needs to show the blue highlight effect when hovering, and the result of my test on react-ant-design is a The highlight effect of the element will also be erased, but I don’t know if this is a bug or a feature it should have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment