Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Old danger buttons still used #6111

Closed
oestrogen opened this issue Nov 27, 2020 · 1 comment · Fixed by #6157
Closed

Modal: Old danger buttons still used #6111

oestrogen opened this issue Nov 27, 2020 · 1 comment · Fixed by #6157

Comments

@oestrogen
Copy link
Contributor

Reproduction link

https://stackblitz.com/edit/angular-nimze4?file=src/app/app.component.ts

Steps to reproduce

Create a modal with a danger button

What is expected?

The documentation for nzOkType says "Button type of the OK button. Consistent with the type of the nz-button."
The button types in nz-button are primary, default, dashed, text, and link. To get a danger nz-button you should use the attribute nzDanger, so I expect to set something like

nzOkType="default"
nzOkDanger="true"

For nzFooter I expect something like

nzFooter: [
        {
          label: "Delete",
          type: "default",
          danger: true
          onClick: () => delete()
        }
      ]

What is actually happening?

I have to use nzOkType="danger" or type: "danger" as there is no property for nzOkDanger or configuration item for danger (There is a configuration item for ghost in nzFooter/ModalButtonOptions though)

This gives me primary danger buttons using the old class ant-btn-danger instead of the new ant-btn-primary ant-btn-dangerous

Environment Info
ng-zorro-antd 10.1.2
Browser Any
@zorro-bot
Copy link

zorro-bot bot commented Nov 30, 2020

Hello @oestrogen. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @oestrogen, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants