Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker: Add nzId to be able to create linked label #6242

Closed
oestrogen opened this issue Dec 21, 2020 · 1 comment
Closed

DatePicker: Add nzId to be able to create linked label #6242

oestrogen opened this issue Dec 21, 2020 · 1 comment
Assignees
@wenqi73
Labels
Component: DatePicker help wanted

Comments

@oestrogen
Copy link
Contributor

Reproduction link

https://stackblitz.com/edit/angular-aeu9j9?file=src/app/app.component.ts

Steps to reproduce

  • Try to use nzId with datePicker.

What is expected?

I want to be able to link a label/nz-form-label with for/nzFor to a date-picker's input element, like I can do with nzId with an inputNumber

What is actually happening?

It's not possible to connect a label to a date-picker.

Environment Info
ng-zorro-antd 11.0.0
Browser Any
@zorro-bot
Copy link

zorro-bot bot commented Dec 21, 2020

Hello @oestrogen. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @oestrogen, 我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板，提供改动所需相应的测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！
giphy

oestrogen added a commit to oestrogen/ng-zorro-antd that referenced this issue Dec 22, 2020
@oestrogen
feat(module:date-picker): support nzId (NG-ZORRO#6242)
8f84873
@oestrogen oestrogen mentioned this issue Dec 22, 2020
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Jan 22, 2021
@oestrogen
feat(module:date-picker): support nzId (#6242) (#6246)
1e9f8bd
ZhWent pushed a commit to ZhWent/ng-zorro-antd that referenced this issue Mar 3, 2021
Merge remote-tracking branch 'upsteam/master'
9df8c93 
* upsteam/master:
  fix(schematics): fix `add-icon-assets`  schema path (NG-ZORRO#6404)
  fix(module:tree-view): correct API typo (NG-ZORRO#6386)
  chore(release): release 11.1.0 (NG-ZORRO#6371)
  fix(module:table): fix table `nzBordered` (NG-ZORRO#6367)
  fix(module:typography): edit area cannot get the content (NG-ZORRO#6369)
  feat(module:table): add support for ReadonlyArray (NG-ZORRO#6156)
  build: update to 11.1 (NG-ZORRO#6365)
  chore: sync ant-design v4.10.3 (NG-ZORRO#6364)
  feat(module:table): support nzPaginationType property (NG-ZORRO#5986)
  feat(module:date-picker): support nzId (NG-ZORRO#6242) (NG-ZORRO#6246)
  feat(module:upload): support `NzUploadFile` parameter of `nzIconRender` (NG-ZORRO#6283)
  feat(module:modal): add nzCentered for modal (NG-ZORRO#6333)
  chore: sync ant-design v4.10.2 (NG-ZORRO#6334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wenqi73 wenqi73

Labels
Component: DatePicker help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oestrogen @vthinkxie @wenqi73