Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:date-picker): support nzId (#6242) #6246

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

oestrogen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6242

What is the new behavior?

Possible to add id attribute to the input of an nz-date-picker component.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #6246 (8f84873) into master (b4648ed) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6246      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.02%     
==========================================
  Files         477      477              
  Lines       15186    15188       +2     
  Branches     2298     2298              
==========================================
  Hits        13639    13639              
- Misses        948      949       +1     
- Partials      599      600       +1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 93.37% <100.00%> (+0.04%) ⬆️
components/date-picker/picker.component.ts 88.75% <100.00%> (+0.07%) ⬆️
components/tabs/tab-nav-bar.component.ts 82.39% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4648ed...8f84873. Read the comment docs.

@zorro-bot
Copy link

zorro-bot bot commented Dec 22, 2020

This preview will be available after the AzureCI is passed.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 1e9f8bd into NG-ZORRO:master Jan 22, 2021
@oestrogen oestrogen deleted the #6242-add-nzId-to-DatePicker branch January 22, 2021 09:24
ZhWent pushed a commit to ZhWent/ng-zorro-antd that referenced this pull request Mar 3, 2021
* upsteam/master:
  fix(schematics): fix `add-icon-assets`  schema path (NG-ZORRO#6404)
  fix(module:tree-view): correct API typo (NG-ZORRO#6386)
  chore(release): release 11.1.0 (NG-ZORRO#6371)
  fix(module:table): fix table `nzBordered` (NG-ZORRO#6367)
  fix(module:typography): edit area cannot get the content (NG-ZORRO#6369)
  feat(module:table): add support for ReadonlyArray (NG-ZORRO#6156)
  build: update to 11.1 (NG-ZORRO#6365)
  chore: sync ant-design v4.10.3 (NG-ZORRO#6364)
  feat(module:table): support nzPaginationType property (NG-ZORRO#5986)
  feat(module:date-picker): support nzId (NG-ZORRO#6242) (NG-ZORRO#6246)
  feat(module:upload): support `NzUploadFile` parameter of `nzIconRender` (NG-ZORRO#6283)
  feat(module:modal): add nzCentered for modal (NG-ZORRO#6333)
  chore: sync ant-design v4.10.2 (NG-ZORRO#6334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants