Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:upload): fix ngModel was changed to nzPercent in nz-progress #1320

Merged
merged 2 commits into from
Apr 13, 2018
Merged

fix(module:upload): fix ngModel was changed to nzPercent in nz-progress #1320

merged 2 commits into from
Apr 13, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 12, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1209

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #1320 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
+ Coverage   97.34%   97.35%   +0.01%     
==========================================
  Files         191      191              
  Lines        7904     7904              
  Branches     1034     1034              
==========================================
+ Hits         7694     7695       +1     
  Misses         21       21              
+ Partials      189      188       -1
Impacted Files Coverage Δ
components/upload/nz-upload-list.component.ts 100% <ø> (ø) ⬆️
components/progress/nz-progress.component.ts 96.58% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de55288...4f0ceab. Read the comment docs.

@vthinkxie vthinkxie merged commit 9b7336e into NG-ZORRO:master Apr 13, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants