Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:date-picker): refactoring and add new feature of year-picker #1906

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

wilsoncook
Copy link
Member

…onth panel

close #1899

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #416

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #1906 into master will decrease coverage by 0.02%.
The diff coverage is 96.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
- Coverage   95.97%   95.95%   -0.03%     
==========================================
  Files         466      468       +2     
  Lines       11217    11240      +23     
  Branches     1474     1473       -1     
==========================================
+ Hits        10766    10785      +19     
  Misses        131      131              
- Partials      320      324       +4
Impacted Files Coverage Δ
components/date-picker/month-picker.component.ts 88.88% <100%> (-11.12%) ⬇️
...e-picker/lib/calendar/calendar-header.component.ts 98.71% <100%> (-0.02%) ⬇️
components/date-picker/date-picker.module.ts 100% <100%> (ø) ⬆️
components/date-picker/year-picker.component.ts 88.88% <88.88%> (ø)
components/date-picker/header-picker.component.ts 97.14% <97.14%> (ø)
components/table/nz-table.component.ts 94.76% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7a6cb...3ab84ef. Read the comment docs.

@vthinkxie vthinkxie merged commit f1f5625 into NG-ZORRO:master Aug 3, 2018
@wilsoncook wilsoncook deleted the feat_yearpicker branch August 3, 2018 10:55
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-month-picker has error view 1,3,3,5,5,7,8,10,10,12,12
2 participants