Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): provide custom scroll strategy #2095

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Sep 4, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2070

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #2095 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
+ Coverage   95.96%   95.97%   +0.01%     
==========================================
  Files         473      475       +2     
  Lines       11516    11538      +22     
  Branches     1535     1536       +1     
==========================================
+ Hits        11051    11074      +23     
  Misses        132      132              
+ Partials      333      332       -1
Impacted Files Coverage Δ
...ts/core/overlay/scroll/nz-block-scroll-strategy.ts 100% <100%> (ø)
components/drawer/nz-drawer.component.ts 97.05% <100%> (+0.23%) ⬆️
.../core/overlay/scroll/nz-scroll-strategy-options.ts 100% <100%> (ø)
components/tabs/nz-tabset.component.ts 96.58% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca1fdd...60c544e. Read the comment docs.

@simplejason simplejason merged commit b993068 into NG-ZORRO:master Sep 7, 2018
@smile2014
Copy link

更新后,现在闪屏很严重

@hsuanxyz hsuanxyz deleted the drawer/fix-scroll branch October 23, 2018 10:35
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants