feat(module:date-picker): support DOWN_ARROW/UP_ARROW/LEFT_ARROW/RIGH… #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsoncook
force-pushed
the
feat-datepicker-hotkey
branch
from
d294f8a
to
ffd7068
Compare
Codecov Report
@@ Coverage Diff @@
## master #2237 +/- ##
==========================================
+ Coverage 95.5% 95.57% +0.07%
==========================================
Files 495 486 -9
Lines 12098 12053 -45
Branches 1689 1608 -81
==========================================
- Hits 11554 11520 -34
- Misses 172 186 +14
+ Partials 372 347 -25
Continue to review full report at Codecov.
|
wilsoncook
force-pushed
the
feat-datepicker-hotkey
branch
from
ffd7068
to
ec4169c
Compare
…T_ARROW/PAGE_DOWN/PAGE_UP/ENTER hotkeys close NG-ZORRO#2094
wilsoncook
force-pushed
the
feat-datepicker-hotkey
branch
from
ec4169c
to
9f632a0
Compare
wilsoncook
force-pushed
the
feat-datepicker-hotkey
branch
from
39d51ce
to
4bff7af
Compare
|
Some other components like select, cascader have similar behaviors. Should abstract these behaviors in another pr later. |
JLHwung
reviewed
Dec 2, 2018
| @@ -741,6 +867,11 @@ describe('NzDatePickerComponent', () => { | |||
| fixture.detectChanges(); | |||
| } | |||
|
|
|||
| function triggerKeydown(node: Node, keyCode: number, ctrlKey: boolean = false, metaKey: boolean = false): void { | |||
| // tslint:disable-next-line:no-any | |||
| dispatchEvent(node, new KeyboardEvent('keydown', { keyCode, ctrlKey, metaKey } as any)); // NOTE: don't use `dispatchKeyboardEvent` (not reliable), it will always set `event.metaKey` tobe `true` | |||
windyflying
reviewed
Dec 2, 2018
| } | ||
|
|
||
| const ctrlKey = event.ctrlKey || event.metaKey; // NOTE: metaKey is the "⌘ Command" key on `MAC` and the "⊞ Windows" key on `Windows` | ||
| switch (event.keyCode) { |
There was a problem hiding this comment.
Maybe it is a good idea that the event.preventDefault() should be outside the switch block
|
@wilsoncook rebase needed. |
vthinkxie
added
PR: reviewed-changes-requested
and removed
PR::wave: Need Change
labels
|
As there is no update for a long time, the current PR has been closed. If you have any questions, feel free to open another PR, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…T_ARROW/PAGE_DOWN/PAGE_UP/ENTER hotkeys
close #2094
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2094
What is the new behavior?
Does this PR introduce a breaking change?
Other information