refactor(module:affix): refactor affix #2544

cipchk · 2018-11-27T12:59:31Z

the nzTarget support string value

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- the nzTarget support string value

codecov · 2018-11-27T13:10:48Z

Codecov Report

Merging #2544 into next will decrease coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next    #2544      +/-   ##
==========================================
- Coverage   95.72%   95.49%   -0.23%     
==========================================
  Files         491      495       +4     
  Lines       12245    12087     -158     
  Branches     1681     1688       +7     
==========================================
- Hits        11721    11543     -178     
- Misses        153      172      +19     
- Partials      371      372       +1

Impacted Files	Coverage Δ
components/affix/nz-affix.component.ts	`100% <100%> (ø)`	⬆️
components/breadcrumb/nz-breadcrumb.component.ts	`52.5% <0%> (-34.74%)`	⬇️
components/transfer/nz-transfer.component.ts	`97.89% <0%> (-2.11%)`	⬇️
components/input/nz-input.directive.ts	`94.44% <0%> (-1.86%)`	⬇️
components/icon/nz-icon.directive.ts	`92.59% <0%> (-1.67%)`	⬇️
components/table/nz-table.component.ts	`95.55% <0%> (-1.12%)`	⬇️
components/cascader/nz-cascader.component.ts	`95.9% <0%> (-0.85%)`	⬇️
components/steps/nz-steps.component.ts	`98.14% <0%> (-0.41%)`	⬇️
...ponents/auto-complete/nz-autocomplete.component.ts	`96.38% <0%> (-0.09%)`	⬇️
components/upload/nz-upload.component.ts	`99.33% <0%> (-0.05%)`	⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6361b6...f5cd7b0. Read the comment docs.

vthinkxie · 2018-11-30T06:39:45Z

components/affix/nz-affix.component.ts

@@ -1,10 +1,12 @@
 // tslint:disable:no-any


should be removed

vthinkxie · 2018-11-30T07:15:39Z

ci build failed

vthinkxie · 2018-11-30T08:39:32Z

components/affix/nz-affix.component.ts

-  styles         : [
-    `:host {
+  styles         : [ `
+    :host {


:host won't work in ViewEncapsulation.None should be nz-affix

* docs: update NG-ZORRO logo (#2425) * fix(module:collapse): can't fold up active panel with accordion (#2440) close #2437 * chore: update styles(ant-design 3.10.7) (#2432) * chore: update styles(ant-design 3.10.8) (#2475) * feat: Adds danish locale (#2486) close #2485 * fix(module:menu): fix dropdown menu item selected className (#2434) close #2433 * fix(module:list): fix invalid render empty style when unspecified data source (#2415) close #2385 * docs(module:modal): add missing nzClassName property (#2400) * docs: add faq in icons docs (#2459) * fix(module:menu): fix fold menu (#2454) close #2449 * refactor(module:all): use cdk keycodes instead of magic number (#2499) * release(1.8.1): release 1.8.1 (#2523) * chore: update styles(ant-design 3.10.9) (#2525) * fix(readme): fix misspelling (#2472) * refactor(module:all): support Angular 7.0 (#2372) * refactor(module:all): refactor component to support onPush & SSR * refactor(module:badge): refactor badge * refactor(module:button & card): refactor * test(module:button): fix test case * fix(module:avatar): fix avatar * fix(module:tree): fix tree tslint * fix(module:tree): fix tree module * fix(module:all): fix tslint config * refactor(module:all): upgrade to angular 7.0 * fix(module:all): fix typescript error * fix(module:build): fix build less options * fix(module:integration): fix webpack test * build: rm unused package * build: fix build & ci * test(module:spin): fix test error * docs: update readme * refactor(module:checkbox): support checkbox onPush (#2478) * docs: update NG-ZORRO logo (#2425) * fix(module:collapse): can't fold up active panel with accordion (#2440) close #2437 * chore: update styles(ant-design 3.10.7) (#2432) * refactor(module:checkbox): support checkbox onPush * refactor(module:collapse): support onPush in collapse (#2481) * refactor(module:divider): refactor divider (#2482) ref #2381 * refactor(module:form): refactor form (#2493) * refactor(module:grid): refactor grid module (#2498) * refactor(module:layout): refactor layout (#2500) * feat(module:progress): support custom strokeColor and strokeLinecap (#2404) close #2378 * feat(module:avatar): support custom size (#2416) close #2380 * fix(module:timeline): fix loading icon (#2386) close #2377 * feat(module:drawer): add input property in NzDrawerRef (#2464) close #2403 * refactor(module:radio): refactor radio to support OnPush (#2519) * refactor(module:spin): refactor spin (#2530) * refactor(module:alert & card): refactor card & refactor template outlet (#2532) * refactor(module:switch & checkbox): refactor switch & checkbox (#2533) * refactor(module:core): refactor input convert decorators (#2535) ref #2474 * refactor(module:mention): refactor mention (#2510) ref: #2381 * refactor(module:steps): refactor steps (#2512) ref #2381 * feat(module:modal): support clicking ESC to close modal (#2483) close #1999 * refactor(module:breadcrumb): refactor breadcrumb (#2513) ref #2381 * refactor(module:skeleton): refactor skeleton (#2514) ref #2381 * refactor(module:icon): refactor icon (#2517) ref #2381 * refactor(module:tree-select): refactor tree-select (#2528) ref: #2381 * build: bump webpack integration (#2524) build: bump webpack integration * refactor(module:timeline): refactor timeline (#2515) close #2379 * support alternate positions, alternate and right alternate * support reversing * refactor(module:autocomplete): refactor autocomplete (#2505) ref #2381, close #2420 * refactor(module:cascader): refactor cascader (#2516) * refactor(module:cascader): refactor cascader close #2935 ref #2198 * fix(module:cascader): fix isFocused access * refactor(module:avatar): refactor avatar (#2536) * fix(module:avatar): fix text style * refactor(module:avatar): refactor avatar ref: #2381 * refactor(module:upload): refactor upload (#2555) * refactor(module:upload): refactor upload - feat: add `nzOpenFileDialogOnClick` prop to allow setting whether to open the upload dialog when the component is clicked * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:list): refactor list (#2548) * refactor(module:list): refactor list * fix: import scrolling in share module * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:transfer): refactor transfer (#2553) * refactor(module:transfer): refactor transfer - feat: add nzDisabled property - need verify design details, ant-design/ant-design#13330 * chore: search muse be disabled * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:back-top): refactor back-top (#2547) refactor(module:back-top): refactor back-top * refactor(module:anchor): refactor anchor (#2546) * refactor(module:anchor): refactor anchor - feat: the nzTarget support string value - fix: invalid id in demo * chore: add encapsulation:ViewEncapsulation.None * chore: add encapsulation:ViewEncapsulation.None * chore: fix display style in host * chore: remove :host ref #2381 * refactor(module:affix): refactor affix (#2544) * refactor(module:affix): refactor affix - the nzTarget support string value * fix: release * style: removed no-any in first line * fix: fix style * chore: fix test * chore: fix display style in host * chore: remove :host

* refactor(module:affix): refactor affix - the nzTarget support string value * fix: release * style: removed no-any in first line * fix: fix style * chore: fix test * chore: fix display style in host * chore: remove :host

cipchk added 2 commits November 27, 2018 20:58

refactor(module:affix): refactor affix

fa0a08f

- the nzTarget support string value

fix: release

40d7d77

vthinkxie requested changes Nov 30, 2018

View reviewed changes

components/affix/nz-affix.component.ts Outdated

@@ -1,10 +1,12 @@

// tslint:disable:no-any

Copy link

Member

vthinkxie Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed

cipchk added 2 commits November 30, 2018 14:52

style: removed no-any in first line

54819d5

fix: fix style

067f8bf

cipchk added 2 commits November 30, 2018 16:19

chore: fix test

7cf4bb9

chore: fix display style in host

fcbde8d

vthinkxie mentioned this pull request Nov 30, 2018

MILESTONE: LATE 2018 #2381

Closed

86 tasks

vthinkxie requested changes Nov 30, 2018

View reviewed changes

chore: remove :host

f5cd7b0

vthinkxie merged commit 9f48b8f into NG-ZORRO:next Nov 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(module:affix): refactor affix #2544

refactor(module:affix): refactor affix #2544

cipchk commented Nov 27, 2018

codecov bot commented Nov 27, 2018 •

edited

Loading

vthinkxie Nov 30, 2018

vthinkxie commented Nov 30, 2018

vthinkxie Nov 30, 2018

refactor(module:affix): refactor affix #2544

refactor(module:affix): refactor affix #2544

Conversation

cipchk commented Nov 27, 2018

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

codecov bot commented Nov 27, 2018 • edited Loading

Codecov Report

vthinkxie Nov 30, 2018

Choose a reason for hiding this comment

vthinkxie commented Nov 30, 2018

vthinkxie Nov 30, 2018

Choose a reason for hiding this comment

codecov bot commented Nov 27, 2018 •

edited

Loading