Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong module name #2556

Closed
wants to merge 2 commits into from
Closed

Wrong module name #2556

wants to merge 2 commits into from

Conversation

bobo0902
Copy link

@bobo0902 bobo0902 commented Nov 29, 2018

No description provided.

NgZorroAntModule→NgZorroAntdModule
NgZorroAntModule→NgZorroAntdModule
@netlify
Copy link

netlify bot commented Nov 29, 2018

Deploy preview for ng-zorro-master ready!

Built with commit ffa18a1

https://deploy-preview-2556--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #2556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2556   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         485      485           
  Lines       12314    12314           
  Branches     1673     1673           
=======================================
  Hits        11802    11802           
  Misses        151      151           
  Partials      361      361

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8cdfc...ffa18a1. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your correction. Please clean up your commit message to follow our contributing guide. We will merge your code after that.

@wzhudev
Copy link
Member

wzhudev commented Nov 29, 2018

@bobo0902 Please clean up your commit message.

@vthinkxie
Copy link
Member

fixed in #2472 closed

@vthinkxie vthinkxie closed this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants