Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:radio): fix radio ContentChildren error #2660

Merged
merged 1 commit into from
Dec 19, 2018
Merged

fix(module:radio): fix radio ContentChildren error #2660

merged 1 commit into from
Dec 19, 2018

Conversation

vthinkxie
Copy link
Member

close #2206 close #2611

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Dec 19, 2018

Deploy preview for ng-zorro-master ready!

Built with commit 5dad146

https://deploy-preview-2660--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #2660 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2660      +/-   ##
==========================================
- Coverage   95.63%   95.62%   -0.01%     
==========================================
  Files         495      495              
  Lines       12079    12079              
  Branches     1687     1687              
==========================================
- Hits        11552    11551       -1     
  Misses        169      169              
- Partials      358      359       +1
Impacted Files Coverage Δ
components/radio/nz-radio-group.component.ts 93.33% <100%> (ø) ⬆️
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f41f8...5dad146. Read the comment docs.

@vthinkxie vthinkxie merged commit 36b2099 into NG-ZORRO:master Dec 19, 2018
@vthinkxie vthinkxie deleted the fix-radio branch February 26, 2019 07:09
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngClas NzRadio [radio-group] can't programmatically set value when OnPush
1 participant