-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(module:select): refactor select to support onPush #2741
Conversation
Deploy preview for ng-zorro-master ready! Built with commit fe60f74 |
Codecov Report
@@ Coverage Diff @@
## master #2741 +/- ##
==========================================
- Coverage 95.57% 95.21% -0.36%
==========================================
Files 507 509 +2
Lines 12086 12043 -43
Branches 1701 1687 -14
==========================================
- Hits 11551 11467 -84
- Misses 171 210 +39
- Partials 364 366 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2741 +/- ##
=========================================
- Coverage 95.57% 95.48% -0.1%
=========================================
Files 515 518 +3
Lines 12191 12238 +47
Branches 1711 1684 -27
=========================================
+ Hits 11652 11685 +33
- Misses 173 192 +19
+ Partials 366 361 -5
Continue to review full report at Codecov.
|
…2741) * refactor(module:select): refactor select to support onPush * refactor(module:select): move to service * refactor(module:select): refactor option-container * feat(module:select): support maxTagCount & maxTagCountPlaceholder * feat(module:select): sync feat and demo with antd * test(module:select): add test for select
…2741) * refactor(module:select): refactor select to support onPush * refactor(module:select): move to service * refactor(module:select): refactor option-container * feat(module:select): support maxTagCount & maxTagCountPlaceholder * feat(module:select): sync feat and demo with antd * test(module:select): add test for select
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
close #1661 close #2030 close #2034 close #2100 close #2421 close #2725