Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:select): refactor select to support onPush #2741

Merged
merged 6 commits into from
Jan 17, 2019
Merged

refactor(module:select): refactor select to support onPush #2741

merged 6 commits into from
Jan 17, 2019

Conversation

vthinkxie
Copy link
Member

@vthinkxie vthinkxie commented Jan 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
1. nzDropdownMatchSelectWidth correct reversed
2. nzSelect OnPush [ngModel]="value" value.push won't change.
[ ] No

Other information

close #1661 close #2030 close #2034 close #2100 close #2421 close #2725

@netlify
Copy link

netlify bot commented Jan 4, 2019

Deploy preview for ng-zorro-master ready!

Built with commit fe60f74

https://deploy-preview-2741--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #2741 into master will decrease coverage by 0.35%.
The diff coverage is 92.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
- Coverage   95.57%   95.21%   -0.36%     
==========================================
  Files         507      509       +2     
  Lines       12086    12043      -43     
  Branches     1701     1687      -14     
==========================================
- Hits        11551    11467      -84     
- Misses        171      210      +39     
- Partials      364      366       +2
Impacted Files Coverage Δ
components/select/nz-option.pipe.ts 100% <ø> (ø) ⬆️
components/select/nz-select.service.ts 100% <100%> (ø)
components/select/nz-select.module.ts 100% <100%> (ø) ⬆️
components/core/addon/addon.module.ts 100% <100%> (ø) ⬆️
components/select/nz-option.component.ts 100% <100%> (ø) ⬆️
components/select/nz-option-li.component.ts 100% <100%> (ø) ⬆️
components/select/nz-option-group.component.ts 87.5% <75%> (-12.5%) ⬇️
components/select/nz-option-container.component.ts 74.82% <84.31%> (-17.68%) ⬇️
...mponents/select/nz-select-top-control.component.ts 79% <89.18%> (-18.73%) ⬇️
components/core/addon/classlist_add.ts 91.66% <91.66%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c821d56...2d317e9. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #2741 into master will decrease coverage by 0.09%.
The diff coverage is 92.52%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2741     +/-   ##
=========================================
- Coverage   95.57%   95.48%   -0.1%     
=========================================
  Files         515      518      +3     
  Lines       12191    12238     +47     
  Branches     1711     1684     -27     
=========================================
+ Hits        11652    11685     +33     
- Misses        173      192     +19     
+ Partials      366      361      -5
Impacted Files Coverage Δ
components/time-picker/nz-time-picker.component.ts 89.79% <ø> (ø) ⬆️
components/core/animation/zoom.ts 100% <100%> (ø)
components/select/nz-option-group.component.ts 100% <100%> (ø) ⬆️
...mponents/dropdown/nz-dropdown-context.component.ts 100% <100%> (ø) ⬆️
components/core/addon/addon.module.ts 100% <100%> (ø) ⬆️
components/date-picker/picker.component.ts 97.75% <100%> (ø) ⬆️
components/select/nz-select.module.ts 100% <100%> (ø) ⬆️
components/core/animation/animation.ts 100% <100%> (ø) ⬆️
...mponents/select/nz-select-top-control.component.ts 100% <100%> (+2.27%) ⬆️
components/select/nz-option-li.component.ts 100% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7eb798...fe60f74. Read the comment docs.

@vthinkxie vthinkxie changed the title [WIP] refactor(module:select): refactor select to support onPush refactor(module:select): refactor select to support onPush Jan 16, 2019
@vthinkxie vthinkxie merged commit e5bafdb into NG-ZORRO:master Jan 17, 2019
@vthinkxie vthinkxie mentioned this pull request Jan 17, 2019
86 tasks
@vthinkxie vthinkxie deleted the refactor-select branch February 26, 2019 07:08
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…2741)

* refactor(module:select): refactor select to support onPush

* refactor(module:select): move to service

* refactor(module:select): refactor option-container

* feat(module:select): support maxTagCount & maxTagCountPlaceholder

* feat(module:select): sync feat and demo with antd

* test(module:select): add test for select
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…2741)

* refactor(module:select): refactor select to support onPush

* refactor(module:select): move to service

* refactor(module:select): refactor option-container

* feat(module:select): support maxTagCount & maxTagCountPlaceholder

* feat(module:select): sync feat and demo with antd

* test(module:select): add test for select
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment