Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): fix nzNodes type #2992

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit fea5f94

https://deploy-preview-2992--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #2992 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2992      +/-   ##
==========================================
+ Coverage   97.35%   97.35%   +<.01%     
==========================================
  Files         548      550       +2     
  Lines       11441    11450       +9     
  Branches      813      813              
==========================================
+ Hits        11138    11147       +9     
  Misses        190      190              
  Partials      113      113
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.component.ts 99.48% <100%> (ø) ⬆️
components/tree/public-api.ts 100% <0%> (ø)
components/tree/index.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87e8bb...fea5f94. Read the comment docs.

@hsuanxyz hsuanxyz self-requested a review February 28, 2019 09:21
fix(module: tree-select): fix spec test
@hsuanxyz hsuanxyz changed the title fix(module: tree-select): fix nzNodes type fix(module:tree-select): fix nzNodes type Feb 28, 2019
@simplejason simplejason merged commit c435853 into NG-ZORRO:master Feb 28, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
fix(module: tree-select): fix spec test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
fix(module: tree-select): fix spec test
@simplejason simplejason deleted the fix-tree-select branch November 23, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants