-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:descriptions): add component #3327
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 5402c94 |
Codecov Report
@@ Coverage Diff @@
## master #3327 +/- ##
==========================================
+ Coverage 95.6% 95.67% +0.06%
==========================================
Files 609 690 +81
Lines 13250 13687 +437
Branches 1810 1821 +11
==========================================
+ Hits 12668 13095 +427
- Misses 197 201 +4
- Partials 385 391 +6
Continue to review full report at Codecov.
|
close NG-ZORRO#2847 feat(module:descriptions): rename component & add demo fix: fix un-renamed variables WIP feat(module:descriptions): support responsive
Should be merged after this component is shipped in antd. |
I fixed the test for responsive in the grid component. |
--- | ||
category: Components | ||
type: Data Display | ||
title: Descriptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Descriptions | |
title: Description List |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个应该是他们那边搞错了,中英文不一致
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts/prerender/static.paths.ts
里面加一下路由,之后我改一下让他动态生成好了。
* feat(module:descriptions): add component close NG-ZORRO#2847 feat(module:descriptions): rename component & add demo fix: fix un-renamed variables WIP feat(module:descriptions): support responsive * fix: test * fix: test, add responsive test * test: fix grid responsive test by the way * fix: fix typedef of responsiveMap and other fixes * fix: restrict window viewport to pass test * fix: fix * docs: fix docs
* feat(module:descriptions): add component close NG-ZORRO#2847 feat(module:descriptions): rename component & add demo fix: fix un-renamed variables WIP feat(module:descriptions): support responsive * fix: test * fix: test, add responsive test * test: fix grid responsive test by the way * fix: fix typedef of responsiveMap and other fixes * fix: restrict window viewport to pass test * fix: fix * docs: fix docs
close #2847
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2847
What is the new behavior?
Does this PR introduce a breaking change?
Other information