-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:avatar): Prioritize icons and text #4138
Conversation
Deploy preview for ng-zorro-master ready! Built with commit bf616c0 |
@Eusen NG-ZORRO 的样式应该与 https://github.com/ant-design/ant-design 保持同步,你可以向他们提交 PR,合并后我们将自动同步样式 |
那这里的修改我给他删掉? |
Codecov Report
@@ Coverage Diff @@
## master #4138 +/- ##
==========================================
- Coverage 92.27% 92.25% -0.02%
==========================================
Files 517 517
Lines 10961 10961
Branches 1985 1985
==========================================
- Hits 10114 10112 -2
- Misses 421 422 +1
- Partials 426 427 +1
Continue to review full report at Codecov.
|
@Eusen Hi,你需要 Rebase 一下 Master 代码,我们刚才修复了一个 CI 的问题 |
了解 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Eusen 请 rebase onto master ,否则 ci 会有问题
恕在下git玩的不是很6,确实不知道该怎么操作。。 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
利用
object-fit: cover
解决了avatar
图片被压缩的问题提高了 text 的优先级,同时存在 icon 和 text,会优先显示text
Does this PR introduce a breaking change?
Other information