Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:*): fix style error with 3.23.6 #4258

Merged
merged 1 commit into from
Oct 9, 2019
Merged

fix(module:*): fix style error with 3.23.6 #4258

merged 1 commit into from
Oct 9, 2019

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Oct 8, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d19c678

https://deploy-preview-4258--ng-zorro-master.netlify.com

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breadcrumb 结构有变化

<div class="ant-breadcrumb">
  <span>
    <a class="ant-breadcrumb-link">
      <i>...</i>
      <span>Application List</span>
    </a>
    <span class="ant-breadcrumb-separator">/</span>
  </span>
</div>

<nz-breadcrumb class="ant-breadcrumb">
  <nz-breadcrumb-item>
    <span class="ant-breadcrumb-link">
      <a>
        <i>...</i>
        <span>Application List</span>
      </a>
    </span>
    <span class="ant-breadcrumb-separator">/</span>
  </nz-breadcrumb-item>
</nz-breadcrumb>

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下拉按钮 class 不一样

https://ant.design/components/dropdown-cn/#components-dropdown-demo-dropdown-button

- <nz-button-group class="ant-btn-group">
+ <nz-button-group class="ant-btn-group ant-dropdown-button">
  <button class="ant-btn ant-btn-default"><span>DropDown</span></button>
-  <button class="ant-dropdown-trigger ant-btn ant-btn-default ant-btn-icon-only">
+  <button class="ant-dropdown-trigger ant-btn ant-btn-default">
    <i>...</i>
-    <span style="display: none;"></span>
  </button>
</nz-button-group>

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #4258 into master will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4258      +/-   ##
==========================================
- Coverage   92.33%   92.28%   -0.06%     
==========================================
  Files         520      520              
  Lines       10965    10977      +12     
  Branches     1984     1988       +4     
==========================================
+ Hits        10125    10130       +5     
- Misses        418      422       +4     
- Partials      422      425       +3
Impacted Files Coverage Δ
components/grid/nz-col.directive.ts 100% <ø> (ø) ⬆️
components/button/demo/size.ts 100% <ø> (ø) ⬆️
components/button/demo/icon.ts 100% <ø> (ø) ⬆️
components/card/nz-card-grid.directive.ts 100% <100%> (ø) ⬆️
components/button/nz-button.component.ts 94.28% <100%> (+0.16%) ⬆️
components/button/nz-button-group.component.ts 100% <100%> (ø) ⬆️
components/core/logger/logger.ts 38.88% <25%> (-11.12%) ⬇️
components/dropdown/nz-dropdown.directive.ts 83.94% <33.33%> (-2.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fc616...d19c678. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ngIf 应该在 header 上面,否则会有一个空的左边距

-  <div class="ant-skeleton-header">
+  <div class="ant-skeleton-header" *ngIf="!!nzAvatar">
    <span
-      *ngIf="!!nzAvatar"
      class="ant-skeleton-avatar"
      [class.ant-skeleton-avatar-lg]="avatar.size === 'large'"
      [class.ant-skeleton-avatar-sm]="avatar.size === 'small'"
      [class.ant-skeleton-avatar-circle]="avatar.shape === 'circle'"
      [class.ant-skeleton-avatar-square]="avatar.shape === 'square'">
    </span>
  </div>

@hsuanxyz hsuanxyz merged commit 120c5be into NG-ZORRO:master Oct 9, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants