Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:style): added rtl support to input #4266

Closed
wants to merge 6 commits into from
Closed

fix(module:style): added rtl support to input #4266

wants to merge 6 commits into from

Conversation

Abdullah700
Copy link
Contributor

@Abdullah700 Abdullah700 commented Oct 10, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
RTL support for input component
this is the first component if you like my work i can change the other components also

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

changes to support RTL

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 8a39471

https://deploy-preview-4266--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #4266 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4266      +/-   ##
==========================================
+ Coverage   92.28%   92.29%   +<.01%     
==========================================
  Files         520      520              
  Lines       10978    10978              
  Branches     1988     1988              
==========================================
+ Hits        10131    10132       +1     
  Misses        422      422              
+ Partials      425      424       -1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 97.36% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0085fca...8a39471. Read the comment docs.

@vthinkxie
Copy link
Member

Hi @Abdullah700
Thanks a lot to your contribution, all styles in ng-zorro-antd are synced from antd react version via robot, you can submit the style pull request to https://github.com/ant-design/ant-design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants