Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:auto-complete): close the panel when tapping scrollbar on Windows #4551

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Dec 11, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4333

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

ie11

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #4551 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4551      +/-   ##
==========================================
- Coverage   93.24%   93.24%   -0.01%     
==========================================
  Files         519      519              
  Lines       12821    12820       -1     
  Branches     2013     2013              
==========================================
- Hits        11955    11954       -1     
  Misses        451      451              
  Partials      415      415
Impacted Files Coverage Δ
...auto-complete/nz-autocomplete-trigger.directive.ts 95.7% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae3ce3...3396d7d. Read the comment docs.

@wenqi73 wenqi73 merged commit 387ebc1 into NG-ZORRO:master Jan 17, 2020
@pr-triage pr-triage bot added the PR: merged label Jan 17, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ZORRO#4551)

* fix(module:auto-complete): close the panel when tapping scrollbar on Windows

close NG-ZORRO#4333

* test: fix test
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ZORRO#4551)

* fix(module:auto-complete): close the panel when tapping scrollbar on Windows

close NG-ZORRO#4333

* test: fix test
@hsuanxyz hsuanxyz deleted the fix/autocomplete-windows-blur branch August 5, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants