Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:avatar): refactor and aync Ant Design 4 #4662

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

hsuanxyz
Copy link
Member

ref #4634

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@374eb84). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4662   +/-   ##
=========================================
  Coverage          ?   92.95%           
=========================================
  Files             ?      505           
  Lines             ?    12723           
  Branches          ?     1971           
=========================================
  Hits              ?    11827           
  Misses            ?      472           
  Partials          ?      424
Impacted Files Coverage Δ
components/avatar/avatar.module.ts 100% <ø> (ø)
components/avatar/avatar.component.ts 98.41% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374eb84...1c7b679. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 3c41421 into NG-ZORRO:master Mar 2, 2020
@hsuanxyz hsuanxyz deleted the refactor/v9-avatar branch March 2, 2020 08:04
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants